[PATCH] D43388: [clangd] Tracing: name worker threads, and enforce naming scheduled async tasks

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 16 07:44:45 PST 2018


sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, ioeric, jkorous-apple, klimek.

This has a bit of a blast radius, but I think there's enough value in "forcing"
us to give names to these async tasks for debugging. Guessing about what
multithreaded code is doing is so unfun...

The "file" param attached to the tasks may seem to be redundant with the thread
names, but note that thread names are truncated to 15 chars on linux!
We'll be lucky to get the whole basename...


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D43388

Files:
  clangd/ClangdServer.cpp
  clangd/TUScheduler.cpp
  clangd/TUScheduler.h
  clangd/Threading.cpp
  clangd/Threading.h
  clangd/Trace.cpp
  clangd/Trace.h
  unittests/clangd/TUSchedulerTests.cpp
  unittests/clangd/ThreadingTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43388.134617.patch
Type: text/x-patch
Size: 20331 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180216/f65500d2/attachment-0001.bin>


More information about the cfe-commits mailing list