[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

Ed Maste via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 16 06:45:47 PST 2018


emaste added a comment.

Please upload reviews with context (e.g. `git diff -U99999`, `git show -U99999`, or `svn diff -x -U999999`).
See https://llvm.org/docs/Phabricator.html for more info.



================
Comment at: lib/Driver/XRayArgs.cpp:60
       D.Diag(diag::err_drv_clang_unsupported)
           << (std::string(XRayInstrumentOption) + " on non-Linux target OS");
     XRayInstrument = true;
----------------
krytarowski wrote:
> Please make this message generic - replace `non-Linux` target with a better wording.
Maybe just `on target OS` or `on specified target OS`?


https://reviews.llvm.org/D43378





More information about the cfe-commits mailing list