[PATCH] D43281: [AMDGPU] fixes for lds f32 builtins

Daniil Fukalov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 15 13:59:56 PST 2018


dfukalov marked an inline comment as done.
dfukalov added inline comments.


================
Comment at: lib/CodeGen/CGBuiltin.cpp:9866
+  case AMDGPU::BI__builtin_amdgcn_ds_fmax: {
+    llvm::SmallVector<llvm::Value *, 5> Args;
+    for (unsigned I = 0; I != 5; ++I)
----------------
b-sumner wrote:
> Can the pointer argument address space be checked here?
added code to check pointer and flaot parameters
though this part is not active at the moment since the builtins are not processed as custom.
going to switch to custom path by removing attribute of the intrinsics in llvm trunk in next step


https://reviews.llvm.org/D43281





More information about the cfe-commits mailing list