[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

[Jonas Hahnfeld via Phabricator via cfe-commits]

Hahnfeld added inline comments.


================
Comment at: test/Driver/openmp-offload-gpu.c:150
+/// bitcode library that will be found via the LIBRARY_PATH.
+// RUN:   touch /tmp/libomptarget-nvptx-sm_60.bc
+// RUN:   LIBRARY_PATH=/tmp %clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda \
----------------
gtbercea wrote:
> Hahnfeld wrote:
> > This should not be in `/tmp` but probably `%T`.
> I don't think this would have worked since I need to create a file with a specific name in a folder somewhere and the separator is OS specific. I moved the test to a new file where I limit OS to linux.
I'm pretty sure `lit` takes care of this, there are a lot of other tests that do so.


================
Comment at: test/Driver/unix-openmp-offload-gpu.c:15
+/// bitcode library that will be found via the LIBRARY_PATH.
+// RUN:   touch /tmp/libomptarget-nvptx-sm_60.bc
+// RUN:   env LIBRARY_PATH=/tmp
----------------
Hahnfeld wrote:
> I don't see how that solves the problem of using `/tmp`?!?
(Interesting that this works with `%t`, the documentation mentions `%T` for a directory. But as other test cases do the same...)


Repository:
  rC Clang

https://reviews.llvm.org/D43197