[PATCH] D43089: clang: Add ARCTargetInfo

Tatyana Krasnukha via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 14 05:33:36 PST 2018


tatyana-krasnukha added a comment.

Sorry, =default is not applicable in these cases, of course.



================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:8123
+public:
+  ARCABIInfo(CodeGen::CodeGenTypes &CGT) : DefaultABIInfo(CGT) {}
+
----------------
tatyana-krasnukha wrote:
> Better use '= default' instead of {}
> And you even may use inheriting constructor here
Here should be inheriting of base class constructor:
```
using DefaultABIInfo::DefaultABIInfo;
```


https://reviews.llvm.org/D43089





More information about the cfe-commits mailing list