[PATCH] D43230: [clangd] Explicitly initialize all primitive fields in Protocol.h
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Feb 14 02:41:12 PST 2018
ilya-biryukov updated this revision to Diff 134179.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Removed initializers for Optional<> fields, they are not problematic
- Remove ctor from Position, initialize on per-field basis instead.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43230
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdUnit.cpp
clangd/Protocol.h
clangd/SourceCode.cpp
unittests/clangd/ClangdTests.cpp
unittests/clangd/SourceCodeTests.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43230.134179.patch
Type: text/x-patch
Size: 13580 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180214/d462a54b/attachment.bin>
More information about the cfe-commits
mailing list