[PATCH] D43127: [clangd] Stop exposing Futures from ClangdServer operations.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 13 00:15:15 PST 2018


ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: unittests/clangd/ClangdTests.cpp:783
   public:
-    NoConcurrentAccessDiagConsumer(std::promise<void> StartSecondReparse)
-        : StartSecondReparse(std::move(StartSecondReparse)) {}
+    std::atomic<int> Count = {0};
 
----------------
sammccall wrote:
> ilya-biryukov wrote:
> > Maybe use paren initializers?  Looks a bit less curly :-)
> > ```
> > std::atomic<int> Count(0);
> > ```
> This is a member initializer, I think I have to use this syntax :-(
You're right, you have to do braced init here.
Sorry, my mistake.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D43127





More information about the cfe-commits mailing list