[PATCH] D42844: [OpenCL] Add test for atomic pointers.

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 12 09:38:29 PST 2018


Anastasia added a comment.

In https://reviews.llvm.org/D42844#1004663, @Fznamznon wrote:

> Yes, we don't have anything OpenCL specific for atomic pointers. 
>  But we have OpenCL specific in pointers and atomics separately and we have address spaces.
>  Why not to test all at once?


We don't typically do integration testing in Clang to keep the runtime of tests within reasonable bounds. Even though this test is quite small I would say if it doesn't increase our code coverage (test a program path which is not tested yet) I wouldn't  be so keen to add it. As for the pointer type implementation I don't think this test is testing any new behavior to what we already cover by C pointer tests. I don't remember any special rule in OpenCL wrt operations on either atomics or local pointers.


Repository:
  rC Clang

https://reviews.llvm.org/D42844





More information about the cfe-commits mailing list