[PATCH] D42351: Emit DWARF "constructor" calling convention for every supported Clang CC

Adrian Prantl via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 12 09:05:30 PST 2018


aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Looks good with one additional change to the test.

Side note: We should also add all the LLVM extensions to http://wiki.dwarfstd.org/index.php?title=Vendor_Extensions.



================
Comment at: test/CodeGen/debug-info-cc.c:1
+// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -o - -emit-llvm -debug-info-kind=limited %s >%t
+// RUN: %clang_cc1 -triple x86_64-unknown-windows-msvc -o - -emit-llvm -debug-info-kind=limited %s >>%t
----------------
I think I would prefer this to be written as 
```
// RUN: $clang_cc1 ... %s | FileCheck --check-prefix=LINUX
// RUN: $clang_cc1 ... %s | FileCheck --check-prefix=WINDOWS
...


// LINUX: !DISubprogram ...
```


https://reviews.llvm.org/D42351





More information about the cfe-commits mailing list