[PATCH] D43110: [Sema] Don't mark plain MS enums as fixed

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 9 12:40:43 PST 2018


rnk added a comment.

In https://reviews.llvm.org/D43110#1003171, @thakis wrote:

> Nice!
>
> Test?


Yeah, I forgot to get that in. From the test you can see that we have weirdly different behavior in C and C++ mode. Do people care? This is pre-existing behavior. My change makes the enum "unfixed" in C++, which changes the C++ behavior. Changing C mode to match C++ mode seems like it should be a separate change. Do people think we should do that as well?


https://reviews.llvm.org/D43110





More information about the cfe-commits mailing list