[PATCH] D43105: [RISCV] Enable __int128_t and uint128_t through clang flag

[Eli Friedman via Phabricator via cfe-commits]

efriedma added a comment.

> This flag can then be used to build compiler-rt for RISCV32.

Can you give a little more context for why this is necessary?  As far as I know, compiler-rt generally supports building for targets which don't have __int128_t.  (If all riscv targets are supposed to support __int128_t, you can just turn it on without adding a flag.)



================
Comment at: lib/Basic/Targets/RISCV.h:85
+  bool hasInt128Type(const LangOptions &Opts) const override {
+    return Opts.UseInt128;
+  }
----------------
Maybe make this a cross-platform flag, rather than riscv-specific?


================
Comment at: test/Driver/types.c:4
+// RUN: not %clang -c --target=riscv32-unknown-linux-gnu %s \
+// RUN: 2>&1 | FileCheck %s
+
----------------
This test won't work unless the riscv backend is enabled; maybe use -fsyntax-only?


Repository:
  rC Clang

https://reviews.llvm.org/D43105