[PATCH] D42942: [clangd] Collect definitions when indexing.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 8 15:12:00 PST 2018


sammccall updated this revision to Diff 133501.
sammccall marked 6 inline comments as done.
sammccall added a comment.

Address review comments.
Make SymbolsToYAML take an ostream instead of returning a string.
Define SymbolSlab::iterator so googletest will print it as a container.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D42942

Files:
  clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp
  clangd/index/Index.cpp
  clangd/index/Index.h
  clangd/index/Merge.cpp
  clangd/index/SymbolCollector.cpp
  clangd/index/SymbolCollector.h
  clangd/index/SymbolYAML.cpp
  clangd/index/SymbolYAML.h
  clangd/tool/ClangdMain.cpp
  unittests/clangd/IndexTests.cpp
  unittests/clangd/SymbolCollectorTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42942.133501.patch
Type: text/x-patch
Size: 30189 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180208/38d681de/attachment-0001.bin>


More information about the cfe-commits mailing list