[PATCH] D35894: [clangd] Code hover for Clangd

[Simon Marchi via Phabricator via cfe-commits]

simark added inline comments.


================
Comment at: unittests/clangd/XRefsTests.cpp:231
+TEST(Hover, All) {
+
+  struct OneTest {
----------------
ilya-biryukov wrote:
> NIT: remove empty line at the start of the function
Done.


================
Comment at: unittests/clangd/XRefsTests.cpp:233
+  struct OneTest {
+    const char *input;
+    const char *expectedHover;
----------------
ilya-biryukov wrote:
> NIT: Use `StringRef` instead of `const char*`
Done.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D35894