[PATCH] D43041: Add X86 Support to ValidCPUList (enabling march notes)

[Jonas Hahnfeld via Phabricator via cfe-commits]

Hahnfeld added inline comments.


================
Comment at: lib/Basic/Targets/X86.cpp:1670-1672
+#define PROC_ALIAS(ENUM, ALIAS)                                                \
+  if (checkCPUKind(getCPUKind(ALIAS)))                                         \
+    Values.emplace_back(ALIAS);
----------------
Hahnfeld wrote:
> `checkCPUKind()` doesn't define `PROC_ALIAS` so I don't think it can handle the values?
Never mind, the enum value is enough. Silly me :-/


https://reviews.llvm.org/D43041