[PATCH] D43065: [clangd] Remove threading-related code from ClangdUnit.h

[Eric Liu via Phabricator via cfe-commits]

ioeric added inline comments.


================
Comment at: clangd/ClangdUnit.cpp:399
+  std::unique_ptr<CompilerInvocation> CI;
+  {
+    // FIXME(ibiryukov): store diagnostics from CommandLine when we start
----------------
ilya-biryukov wrote:
> ioeric wrote:
> > Do we still need this block?
> I added it to avoid referencing local variables declared there.
> 
> I would move this to be a separate function rather than removing the braces here, but other may have different opinions :-)
> WDYT? Does a separate function sound ok?
I don't think it's necessary though? But up to you :)


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D43065