[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

Ivan Donchevskii via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 8 06:50:55 PST 2018


yvvan added a comment.

In https://reviews.llvm.org/D41005#1001854, @cameron314 wrote:

> @yvvan: The clang frontend tests (`PCHPreambleTest` and friends) are disabled on Windows in the makefile (I think because the VFS tests depend on linux-like paths). So running the tests on Windows without failures is encouraging but not the whole story.


Nice to know. But the bad thing is that it is not obvious at all from the code. And another bad thing is that tests are platform dependent.


Repository:
  rC Clang

https://reviews.llvm.org/D41005





More information about the cfe-commits mailing list