[PATCH] D42915: [clangd] Use URIs in index symbols.

[Eric Liu via Phabricator via cfe-commits]

ioeric added inline comments.


================
Comment at: clangd/index/Index.h:27
+  // The URI of the source file where a symbol occurs.
+  llvm::StringRef FileUri;
   // The 0-based offset to the first character of the symbol from the beginning
----------------
sammccall wrote:
> nit: FileURI?
> (The other style is OK too, though I personally find it harder to read. But the class is `URI` and we should be consistent)
I tend to use `Uri` for URI strings and `URI`/`U` for URI objects.  But I'd be okay with either, if you prefer `URI`. 


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D42915