[PATCH] D42924: Don't pass ForDefinition_t in places it is redundant.

Rafael Avila de Espindola via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 5 11:33:49 PST 2018


espindola created this revision.
espindola added reviewers: sfertile, rnk.

I found this while looking at the ppc failures caused by the  dso_local change.

The issue was that the patch would produce the wrong answer for available_externally. Having ForDefinition_t available in places where the code can just check the linkage is a bit of a foot gun.

This patch removes the ForDefiniton_t argument in places where the linkage is already know.


https://reviews.llvm.org/D42924

Files:
  clang/lib/CodeGen/CGDecl.cpp
  clang/lib/CodeGen/CGVTT.cpp
  clang/lib/CodeGen/CGVTables.cpp
  clang/lib/CodeGen/CodeGenModule.cpp
  clang/lib/CodeGen/CodeGenModule.h
  clang/lib/CodeGen/ItaniumCXXABI.cpp
  clang/lib/CodeGen/TargetInfo.cpp
  clang/lib/CodeGen/TargetInfo.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42924.132871.patch
Type: text/x-patch
Size: 18852 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180205/a7b2d1d4/attachment-0001.bin>


More information about the cfe-commits mailing list