[PATCH] D42887: [Driver] Add option to manually control discarding value names in LLVM IR.

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri added inline comments.


================
Comment at: lib/Driver/ToolChains/Clang.cpp:3269
 
-// Disable the verification pass in -asserts builds.
+  const bool IsAssertBuild =
 #ifdef NDEBUG
----------------
This logic seems sidewards.
If `NDEBUG` is specified, then it is `assert()`-less build.
If `NDEBUG` is *not* specified, then `assert()`'s are actually functional.



================
Comment at: lib/Driver/ToolChains/Clang.cpp:3270
-// Disable the verification pass in -asserts builds.
+  const bool IsAssertBuild =
 #ifdef NDEBUG
-  CmdArgs.push_back("-disable-llvm-verifier");
----------------
`-assert` is `assert()`-less build


https://reviews.llvm.org/D42887