[PATCH] D42672: [CFG] [analyzer] Heavier CFGConstructor elements.

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 2 13:15:32 PST 2018


NoQ added inline comments.


================
Comment at: lib/Analysis/CFG.cpp:653
+  // triggered by the given trigger.
+  void VisitForConstructionContext(Stmt *Trigger, Stmt *Child);
+
----------------
dcoughlin wrote:
> I find the name of this method very confusing. It sounds like you are visiting an AST node called a 'ForConstructionContext', but that is not what this function does. It is also not clear from either the name or the comment what the method is supposed to do. Can you be more precise?
> 
> You can fix this in a follow-up commit if you like.
Yeah i guess i just followed the `VisitForTemporaryDtors` pattern^^ Will fix.


https://reviews.llvm.org/D42672





More information about the cfe-commits mailing list