[PATCH] D42857: testing phabricator email reply

[Eric Liu via Phabricator via cfe-commits]

ioeric created this revision.
Herald added subscribers: cfe-commits, klimek.
ioeric removed rCTE Clang Tools Extra as the repository for this revision.
ioeric removed subscribers: klimek, cfe-commits.
ioeric added a comment.

top Comment



================
Comment at: change-namespace/ChangeNamespace.cpp:42
 
+inline std::string
+joinNamespaces(const llvm::SmallVectorImpl<StringRef> &Namespaces) {
----------------
Test comment 1.


https://reviews.llvm.org/D42857

Files:
  change-namespace/ChangeNamespace.cpp


Index: change-namespace/ChangeNamespace.cpp
===================================================================
--- change-namespace/ChangeNamespace.cpp
+++ change-namespace/ChangeNamespace.cpp
@@ -18,16 +18,6 @@
 
 namespace {
 
-inline std::string
-joinNamespaces(const llvm::SmallVectorImpl<StringRef> &Namespaces) {
-  if (Namespaces.empty())
-    return "";
-  std::string Result = Namespaces.front();
-  for (auto I = Namespaces.begin() + 1, E = Namespaces.end(); I != E; ++I)
-    Result += ("::" + *I).str();
-  return Result;
-}
-
 // Given "a::b::c", returns {"a", "b", "c"}.
 llvm::SmallVector<llvm::StringRef, 4> splitSymbolName(llvm::StringRef Name) {
   llvm::SmallVector<llvm::StringRef, 4> Splitted;
@@ -49,6 +39,16 @@
   return TLoc.getLocStart();
 }
 
+inline std::string
+joinNamespaces(const llvm::SmallVectorImpl<StringRef> &Namespaces) {
+  if (Namespaces.empty())
+    return "";
+  std::string Result = Namespaces.front();
+  for (auto I = Namespaces.begin() + 1, E = Namespaces.end(); I != E; ++I)
+    Result += ("::" + *I).str();
+  return Result;
+}
+
 SourceLocation endLocationForType(TypeLoc TLoc) {
   // Dig past any namespace or keyword qualifications.
   while (TLoc.getTypeLocClass() == TypeLoc::Elaborated ||


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42857.132628.patch
Type: text/x-patch
Size: 1246 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180202/8ab5f29e/attachment.bin>