[PATCH] D42641: [MinGW] Emit typeinfo locally for dllimported classes without key functions
Saleem Abdulrasool via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jan 31 19:23:19 PST 2018
compnerd added a comment.
I think that the new version is better.
================
Comment at: lib/CodeGen/ItaniumCXXABI.cpp:2766
+ // Don't import the RTTI but emit it locally
+ if (CGM.getTriple().isWindowsGNUEnvironment() && IsDLLImport)
+ return false;
----------------
Can't this be simplified to ignore the `IsDLLImport`? If it is export, it should be emitted, if it is import, it should emit it locally. If it is static, it should also emit it locally, no?
https://reviews.llvm.org/D42641
More information about the cfe-commits
mailing list