[PATCH] D41102: Setup clang-doc frontend framework

Julie Hockett via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 31 18:05:28 PST 2018


juliehockett updated this revision to Diff 132306.
juliehockett marked 47 inline comments as done.
juliehockett added a comment.

1. Changing the traversal pattern from using `RecursiveASTVisitor` to using matchers instead. This will allow for a more flexible API (e.g. allowing access to individual nodes, rather than forcing all data on the user).
2. Templatizing lots of things. There was a lot of duplicated code.
3. Fixing comments

I'm going to take a stab at refactoring the serialization part of this next -- rather than keeping it all in memory and dumping it at the end, it should serialize as it goes and do some sort of reduce at the end. I'm currently thinking of writing it out to a file as it goes, and then reading and reducing from there -- thoughts?


https://reviews.llvm.org/D41102

Files:
  test/Tooling/clang-doc-basic.cpp
  test/Tooling/clang-doc-namespace.cpp
  test/Tooling/clang-doc-type.cpp
  tools/clang-doc/ClangDoc.cpp
  tools/clang-doc/ClangDoc.h
  tools/clang-doc/ClangDocReporter.cpp
  tools/clang-doc/ClangDocReporter.h
  tools/clang-doc/ClangDocYAML.h
  tools/clang-doc/tool/ClangDocMain.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41102.132306.patch
Type: text/x-patch
Size: 83628 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180201/cea90e70/attachment-0001.bin>


More information about the cfe-commits mailing list