[PATCH] D42170: Fixit for 'typedef' instead of 'typename' typo

Volodymyr Sapsai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 31 09:53:49 PST 2018


vsapsai accepted this revision.
vsapsai added a comment.
This revision is now accepted and ready to land.

One small note about `-fdiagnostics-parseable-fixits`. The rest looks good to me. And the test looks readable.



================
Comment at: FixIt/fixit-typedef-instead-of-typename-typo.cpp:1
+// RUN: %clang_cc1 -fsyntax-only -fdiagnostics-parseable-fixits -verify %s
+
----------------
I don't think you need `-fdiagnostics-parseable-fixits` here. Though it is required in the second RUN line.


https://reviews.llvm.org/D42170





More information about the cfe-commits mailing list