[PATCH] D41318: Start setting dso_local in clang

Sean Fertile via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 31 07:49:32 PST 2018


sfertile added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:750
+  // If we can use a plt entry as the symbol address we can assume it
+  // is local.
+  if (isa<FunctionDecl>(D) && !CGOpts.NoPLT)
----------------
I don't think this is the case. I think this would break ppc, where we need to restore the toc pointer after the plt stubs returns to the original call site.


https://reviews.llvm.org/D41318





More information about the cfe-commits mailing list