[PATCH] D42517: [clangd] Pass Context implicitly using TLS.

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a comment.

I don't see a patch corresponding to the fixed comments. `arc diff` didn't go through?



================
Comment at: clangd/Trace.cpp:131
+    return Context::current().clone();
+  WithContextValue WithArgs{std::unique_ptr<json::obj>(Args)};
+  return T->beginSpan(Name, Args);
----------------
sammccall wrote:
> ilya-biryukov wrote:
> > Maybe use parentheses instead of braces for initialization?
> Braces here are to avoid most-vexing-parse: with parens this is a function declaration.
> 
> (I'm not sure this is worth a comment, as the compiler flags it if you change it)
LG. No need for a comment.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D42517