[PATCH] D42708: [clang-format] Set BinPackObjCProtocolList to Never for google style

Jacek Olesiak via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 31 01:03:23 PST 2018


jolesiak added inline comments.


================
Comment at: lib/Format/Format.cpp:765
     GoogleStyle.ColumnLimit = 100;
+    GoogleStyle.BinPackObjCProtocolList = FormatStyle::BPS_Never;
   }
----------------
If I understand correctly this is meant to be ObjC-specific flag. I feel like this should be put in general config (next to GoogleStyle.ObjcSpaceAfterProperty and GoogleStyle.ObjCSpaceBeforeProtocolList; ~50 lines above).
To me putting it inside 'if' check means different value is used for ObjC than for other languages (what isn't the case here, as this flag shouldn't be used in formatting other languages code). 


Repository:
  rC Clang

https://reviews.llvm.org/D42708





More information about the cfe-commits mailing list