[PATCH] D42693: [libcxx] Handle invalid escaped characters in POSIX regex

[Marshall Clow via Phabricator via cfe-commits]

mclow.lists added a comment.

I like this.  One nit and a question.



================
Comment at: include/regex:3490
             {
                 switch (*__temp)
                 {
----------------
Do we need any more cases here?


================
Comment at: test/std/re/re.regex/re.regex.construct/bad_escape.pass.cpp:50
 
+    std::regex_constants::syntax_option_type basic =
+        std::regex_constants::basic;
----------------
should be `const`.   (Yes, this is me being picky)


https://reviews.llvm.org/D42693