[PATCH] D42639: [clang-move] Clever on handling header file which includes itself.

[Eric Liu via Phabricator via cfe-commits]

ioeric added inline comments.


================
Comment at: clang-move/ClangMove.cpp:708
+    // Find old.h includes "old.h".
+    if (AbsoluteOldHeader == AbsoluteOldHeader) {
+      OldHeaderIncludeRangeInHeader = IncludeFilenameRange;
----------------
This check is always true?


================
Comment at: clang-move/ClangMove.cpp:869
+    if (Context->Spec.NewCC == NewFile && OldHeaderIncludeRangeInCC.isValid()) {
+      AllCode = AllCode.merge(clang::tooling::Replacements(
+          clang::tooling::Replacement(SM, OldHeaderIncludeRangeInCC,
----------------
I'd pull this into a lambda.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D42639