[PATCH] D42395: [clang-format] Fix bug where -dump-config failed on ObjC header

[Krasimir Georgiev via Phabricator via cfe-commits]

krasimir accepted this revision.
krasimir added inline comments.
This revision is now accepted and ready to land.


================
Comment at: test/Format/lit.local.cfg:1
+# Suffixes supported by clang-format.
+config.suffixes = ['.c', '.cc', '.cpp', '.h', '.m', '.mm', '.java', '.js',
----------------
benhamilton wrote:
> krasimir wrote:
> > Why is this needed?
> '.h' is not in the list of file suffixes which lit is configured to look for:
> 
> https://github.com/llvm-mirror/clang/blob/master/test/lit.cfg.py#L28
> 
> So, we need to provide our own list of file suffixes here.
> 
> Other tests do the same:
> 
> https://github.com/llvm-mirror/clang/search?utf8=%E2%9C%93&q=%22config.suffixes%22&type=
> 
> so I think it's OK to do so here as well.
Thank you!


Repository:
  rC Clang

https://reviews.llvm.org/D42395