[PATCH] D42614: AST: support ObjC lifetime qualifiers in MS ABI

Shoaib Meenai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jan 27 10:43:41 PST 2018


smeenai added a comment.

pin_ptr is technically not supposed to appear as a function parameter, and having it in that position can screw up demangling. Considering __strong is the default, it's probably not a good idea to map that one to pin_ptr; whichever qualifier is least likely to appear as a function parameter (though I don't know which one that is) should map to pin_ptr. The other lifetimes seem to demangle fine wherever you place them.

Do you want to add some tests for the mangling of qualifiers on function parameters themselves? That would also demonstrate the potential demangling issue.


Repository:
  rC Clang

https://reviews.llvm.org/D42614





More information about the cfe-commits mailing list