[PATCH] D42606: [Coroutines] Use allocator overload when available
Brian Gesiak via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jan 26 15:30:59 PST 2018
modocache created this revision.
modocache added reviewers: rsmith, GorNishanov, eric_niebler.
Herald added a subscriber: EricWF.
Depends on https://reviews.llvm.org/D42605.
An implementation of the behavior described in `[dcl.fct.def.coroutine]/7`:
when a promise type overloads `operator new` using a "placement new"
that takes the same argument types as the coroutine function, that
overload is used when allocating the coroutine frame.
Simply passing references to the coroutine function parameters directly
to `operator new` results in invariant violations in LLVM's coroutine
splitting pass, so this implementation modifies Clang codegen to
produce allocator-specific alloc/store/loads for each parameter being
forwarded to the allocator.
Test Plan: `check-clang`
Repository:
rC Clang
https://reviews.llvm.org/D42606
Files:
lib/CodeGen/CGCoroutine.cpp
lib/Sema/SemaCoroutine.cpp
test/CodeGenCoroutines/coro-alloc.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42606.131665.patch
Type: text/x-patch
Size: 7643 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180126/00152ca0/attachment.bin>
More information about the cfe-commits
mailing list