[PATCH] D42581: [NVPTX] Emit debug info in DWARF-2 by default for Cuda devices.

[Artem Belevich via Phabricator via cfe-commits]

tra added inline comments.


================
Comment at: lib/Driver/ToolChains/Cuda.cpp:353
   CmdArgs.push_back(Args.MakeArgString(Output.getFilename()));
+  if (mustEmitDebugInfo(Args) && Args.hasArg(options::OPT_g_Flag))
+    CmdArgs.push_back("-g");
----------------
There's more than one -g option. Presumably you still want -g here for -g{1,2,3} or -ggdb{1,2,3} or -gdwarf2.

Speaking of dwarf, what's going to happen if someone passes -gdwarf5?  Should we downgrade it to -gdwarf2 on device side and issue a warning?



================
Comment at: test/Driver/cuda-dwarf-2.cu:6-11
+// DEFAULT: "-fcuda-is-device"
+// DEFAULT-SAME: "-dwarf-version=2"
+// DEFAULT: ptxas
+// DEFAULT-NOT: "-g"
+// DEFAULT: fatbinary
+// DEFAULT-NOT: "-g"
----------------
Nit: you could probably collapse all test cases into two: HAS_DEBUG/NO_DEBUG


Repository:
  rC Clang

https://reviews.llvm.org/D42581