[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

[Nikhil Gupta via Phabricator via cfe-commits]

nikhgupt added inline comments.
Herald added a subscriber: hintonda.


================
Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:395
+    return XFE && !YFE;
+  return XFE->getName() < YFE->getName();
+}
----------------
getName could yield incorrect results if two files in the project have the same name. This might break the assert for PathDiagnostics 'total ordering' and 'uniqueness'.
Maybe replacing FileEntry's getName with FullSourceLoc's getFileID could resolve this.


https://reviews.llvm.org/D30691