[PATCH] D42459: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.
Don Hinton via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 25 12:13:32 PST 2018
hintonda requested review of this revision.
hintonda added a comment.
I probably should have put this in the summary, but the reason for this patch isn't just to clean up the cmake files, it's to fix a cmake configuration failure when cross-compiling for Linux on Darwin:
CMake Error at /Users/dhinton/projects/llvm_project/libcxx/lib/CMakeLists.txt:224 (add_library):
The install of the cxx_shared target requires changing an RPATH from the
build tree, but this is not supported with the Ninja generator unless on an
ELF-based platform. The CMAKE_BUILD_WITH_INSTALL_RPATH variable may be set
to avoid this relinking step.
Repository:
rCXX libc++
https://reviews.llvm.org/D42459
More information about the cfe-commits
mailing list