Please subscribe "rUNW libunwind" to cfe-commits.

Don Hinton via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 25 11:35:26 PST 2018


Ah, I think that's the issue.

local:/Users/dhinton/projects/llvm_project/libcxxabi $ cat .arcconfig
{
  "repository.callsign" : "CXXA",
  "conduit_uri" : "https://reviews.llvm.org/"
}

So, it should set repository to CXXA, not LLVM.



On Thu, Jan 25, 2018 at 11:25 AM, Ben Hamilton <benhamilton at google.com>
wrote:

> Yes, that's currently a submit time feature built in to Phabricator which
> i believe we'll have to fix upstream.
>
> Because both the top level LLVM SVN report and the sub repos see the same
> files, Phabricator automatically subscribes both lists to the commits.
>
> I wasn't able to find an easy way to disable this feature. If you can find
> one, please let me know! (I was punting in hopes the migration to git would
> happen first.)
>
> On Thu, Jan 25, 2018 at 11:01 AM Don Hinton <hintonda at gmail.com> wrote:
>
>> Btw, I'm seeing other inconsistencies, e.g., I just committed
>> https://reviews.llvm.org/D42460 and herald ended up adding both
>> cfe-commits and llvm-commits to subscribers.
>>
>> When I created it, I left subscribers blank, so herald added cfe-commits
>> -- which seems to be correct.
>> Then, when I committed it, herald added llvm-commits -- which doesn't
>> seem correct.
>>
>>
>>
>> On Thu, Jan 25, 2018 at 10:04 AM, Don Hinton <hintonda at gmail.com> wrote:
>>
>>> Thanks Ben...
>>>
>>> On Thu, Jan 25, 2018 at 9:53 AM, Ben Hamilton <benhamilton at google.com>
>>> wrote:
>>>
>>>> Ah, I see from http://bcain-llvm.readthedocs.io/projects/
>>>> libunwind/en/latest/ that libunwind review discussion does take place
>>>> on cfe-commits.
>>>>
>>>> Added. Sorry about not doing that earlier!
>>>>
>>>> Ben
>>>>
>>>> On Thu, Jan 25, 2018 at 8:37 AM Ben Hamilton <benhamilton at google.com>
>>>> wrote:
>>>>
>>>>> Great question. Is there an existing separate list for libunwind?
>>>>>
>>>>> If libunwind discussion already happens on cfe-commits, then I'll make
>>>>> reviews for libunwind subscribe that list.
>>>>>
>>>>> On Tue, Jan 23, 2018, 21:40 Don Hinton <hintonda at gmail.com> wrote:
>>>>>
>>>>>> Currently, herald doesn't subscribe libunwind to any group.  Should
>>>>>> it be added to cfe-commits?
>>>>>>
>>>>>>   https://reviews.llvm.org/H268
>>>>>>
>>>>>
>>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180125/b799d468/attachment-0001.html>


More information about the cfe-commits mailing list