[libcxxabi] r323455 - [cmake] [libcxxabi] Call llvm_setup_rpath() when adding shared libraries.

Shoaib Meenai via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 25 11:02:59 PST 2018


Same concerns about building standalone as r323453.

From: cfe-commits <cfe-commits-bounces at lists.llvm.org> on behalf of Don Hinton via cfe-commits <cfe-commits at lists.llvm.org>
Reply-To: Don Hinton <hintonda at gmail.com>
Date: Thursday, January 25, 2018 at 10:45 AM
To: "cfe-commits at lists.llvm.org" <cfe-commits at lists.llvm.org>
Subject: [libcxxabi] r323455 - [cmake] [libcxxabi] Call llvm_setup_rpath() when adding shared libraries.

Author: dhinton
Date: Thu Jan 25 10:43:18 2018
New Revision: 323455

URL: https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D323455-26view-3Drev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=hTm6KbFwg4mKjKLP4oJisCnQB5oDNYWxGe5FbWvRMG4&s=aQXMyZsZ0iP8FoN1WB_c71EWuSMWQxCXM-sGKrKadHQ&e=
Log:
[cmake] [libcxxabi] Call llvm_setup_rpath() when adding shared libraries.

Clang and llvm already use llvm_setup_rpath(), so this change will
help standarize rpath usage across all projects.

Differential Revision: https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D42460&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=hTm6KbFwg4mKjKLP4oJisCnQB5oDNYWxGe5FbWvRMG4&s=ar8LZPLycTnAYZym_qLrhMWtMbmSLGMTM-iF0fGYapA&e=

Modified:
    libcxxabi/trunk/src/CMakeLists.txt

Modified: libcxxabi/trunk/src/CMakeLists.txt
URL: https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_libcxxabi_trunk_src_CMakeLists.txt-3Frev-3D323455-26r1-3D323454-26r2-3D323455-26view-3Ddiff&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=hTm6KbFwg4mKjKLP4oJisCnQB5oDNYWxGe5FbWvRMG4&s=Q0L26GZkEGTO8MI8bqktkHHGjnRaeZHZd1kOIR1F8ng&e=
==============================================================================
--- libcxxabi/trunk/src/CMakeLists.txt (original)
+++ libcxxabi/trunk/src/CMakeLists.txt Thu Jan 25 10:43:18 2018
@@ -127,6 +127,7 @@ set(LIBCXXABI_TARGETS)
# Build the shared library.
if (LIBCXXABI_ENABLE_SHARED)
   add_library(cxxabi_shared SHARED $<TARGET_OBJECTS:cxxabi_objects>)
+  llvm_setup_rpath(cxxabi_shared)
   target_link_libraries(cxxabi_shared ${LIBCXXABI_LIBRARIES})
   set_target_properties(cxxabi_shared
                         PROPERTIES


_______________________________________________
cfe-commits mailing list
cfe-commits at lists.llvm.org<mailto:cfe-commits at lists.llvm.org>
https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Dcommits&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=hTm6KbFwg4mKjKLP4oJisCnQB5oDNYWxGe5FbWvRMG4&s=BwX8iu3z7NGRyVxRMdBFsrL01j8I4y_eQ-fw8kW5bLs&e=

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180125/1595ebbd/attachment.html>


More information about the cfe-commits mailing list