[PATCH] D39571: [clangd] DidChangeConfiguration Notification

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a comment.

Hi @simark , thanks for picking up this change.



================
Comment at: clangd/ClangdLSPServer.cpp:302
 
+// FIXME: This function needs to be properly tested.
+void ClangdLSPServer::onChangeConfiguration(
----------------
Are you planning to to address this FIXME before checking the code in?


================
Comment at: clangd/GlobalCompilationDatabase.h:64
 
+  void setCompileCommandsDir(Path P) {
+    std::lock_guard<std::mutex> Lock(Mutex);
----------------
Maybe move definition to `.cpp` file?




Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D39571