[PATCH] D39571: [clangd] DidChangeConfiguration Notification
William Enright via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jan 23 12:37:00 PST 2018
Nebiroth added inline comments.
================
Comment at: clangd/ClangdLSPServer.cpp:78
{"documentHighlightProvider", true},
+ {"configurationChangeProvider", true},
{"renameProvider", true},
----------------
simark wrote:
> I find `configurationChangeProvider` a bit weird. It makes it sound like clangd can provide configuration changes. In reality, it can accept configuration changes. So I think this should be named something else.
Agreed, perhaps configurationChangeManager would be more appropriate then?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D39571
More information about the cfe-commits
mailing list