[PATCH] D42073: [clangd] Use accessible scopes to query indexes for global code completion.

[Haojian Wu via Phabricator via cfe-commits]

hokein added inline comments.


================
Comment at: clangd/CodeComplete.cpp:695
+  Info.UnresolvedQualifier =
+      Lexer::getSourceText(CharSourceRange::getCharRange((*SS)->getRange()),
+                           S.getSourceManager(), clang::LangOptions());
----------------
hokein wrote:
> sammccall wrote:
> > do you need to remove any leading :: here?
> Not needed, as Sema exclues the trailing "::". Added a comment.
Aha, sorry -- I misread the comment. Yeah, we need to remove the leading "::", added a test to catch this bug.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D42073