[PATCH] D42363: [clang-tidy] Don't generate fixes for invalid new expr location in modernize-make-unique.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 23 01:47:20 PST 2018


ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D42363#983769, @hokein wrote:

> Yeah, we should fix the clang bug (root cause). But I think this patch still makes sense -- as we usually ignore invalid cases in clang-tidy checks.


Sure, thanks for clarifying. LGTM.
It's a bit unfortunate that the test will break when we fix an actual bug in clang. But it's just something to watch out for, still nice to have a test after the bug is fixed.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D42363





More information about the cfe-commits mailing list