[PATCH] D42388: [analyzer] Protect against dereferencing a null pointer

[Alexander Shaposhnikov via Phabricator via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL323146: [analyzer] Protect against dereferencing a null pointer (authored by alexshap, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D42388?vs=130935&id=130946#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D42388

Files:
  cfe/trunk/lib/StaticAnalyzer/Core/PathDiagnostic.cpp


Index: cfe/trunk/lib/StaticAnalyzer/Core/PathDiagnostic.cpp
===================================================================
--- cfe/trunk/lib/StaticAnalyzer/Core/PathDiagnostic.cpp
+++ cfe/trunk/lib/StaticAnalyzer/Core/PathDiagnostic.cpp
@@ -1185,6 +1185,9 @@
 StackHintGenerator::~StackHintGenerator() {}
 
 std::string StackHintGeneratorForSymbol::getMessage(const ExplodedNode *N){
+  if (!N)
+    return getMessageForSymbolNotFound();
+
   ProgramPoint P = N->getLocation();
   CallExitEnd CExit = P.castAs<CallExitEnd>();
 
@@ -1194,9 +1197,6 @@
   if (!CE)
     return "";
 
-  if (!N)
-    return getMessageForSymbolNotFound();
-
   // Check if one of the parameters are set to the interesting symbol.
   unsigned ArgIndex = 0;
   for (CallExpr::const_arg_iterator I = CE->arg_begin(),


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42388.130946.patch
Type: text/x-patch
Size: 797 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180122/2c4fc0be/attachment.bin>