[PATCH] D42318: [ARM] Pass _Float16 as int or float

Sam Parker via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 22 08:27:27 PST 2018


samparker added a comment.

Hi Sjoerd,

Seems sensible to me to treat these two types the same way, though I must admit having different half types confuses me... So a few questions for my understanding:

- What issue are you trying to workaround?

-What would the ideal solution be?

- Why do we need a workaround instead of implementing the ideal solution?

cheers!



================
Comment at: test/CodeGen/arm-float16-arguments.c:4
+// RUN: %clang_cc1 -triple armv7a--none-eabi -target-abi aapcs -mfloat-abi soft -fnative-half-arguments-and-returns -emit-llvm -o - -O1 %s | FileCheck %s --check-prefix=NATIVE
+
+_Float16 g;
----------------
Probably worth keeping these in arm-fp16-arguments.c since they're basically the same.


https://reviews.llvm.org/D42318





More information about the cfe-commits mailing list