[PATCH] D42344: [libc++] Use multi-key tree search for {map, set}::{count, equal_range}

[Marshall Clow via Phabricator via cfe-commits]

mclow.lists added a comment.

Sometimes you get lucky ;-)
I have a task for next week that says "The transparent lookup stuff in the associative containers needs tests", and here is this patch.

Instead of "transparent_count.pass.cpp", please name the test "count_transparent.pass.cpp" so it will sort with all the other count tests.



================
Comment at: libcxx/test/std/containers/associative/map/map.ops/transparent_count.pass.cpp   :25
+
+#if TEST_STD_VER <= 11
+#error "This test requires is C++14 (or later)"
----------------
Instead of this, just put
     //  UNSUPPORTED:  c++98, c++03, c++11

near the top of the file.


================
Comment at: libcxx/test/std/containers/associative/map/map.ops/transparent_equal_range.pass.cpp  :28
+
+#if TEST_STD_VER <= 11
+#error "This test requires is C++14 (or later)"
----------------
Same here.


================
Comment at: libcxx/test/std/containers/associative/set/transparent_count.pass.cpp :27
+
+#if TEST_STD_VER <= 11
+#error "This test requires is C++14 (or later)"
----------------
same here.


================
Comment at: libcxx/test/std/containers/associative/set/transparent_equal_range.pass.cpp:29
+
+#if TEST_STD_VER <= 11
+#error "This test requires is C++14 (or later)"
----------------
and here.


https://reviews.llvm.org/D42344