[PATCH] D42273: Add hasTrailingReturn AST matcher

Julie Hockett via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 19 16:28:59 PST 2018


juliehockett added inline comments.


================
Comment at: include/clang/ASTMatchers/ASTMatchers.h:5904
+    return F->hasTrailingReturn();
+  return false;
+}
----------------
lebedev.ri wrote:
> There are no negative tests in the unittest that cover this false path.
Is there a test case you would recommend? I'm not entirely sure what would be appropriate -- the tests compile in C++, yes? So `void f();` would just be a normal function declaration (with a prototype, please correct me if I'm wrong). 


https://reviews.llvm.org/D42273





More information about the cfe-commits mailing list