[PATCH] D42181: [clangd] Merge index-provided completions with those from Sema.

[Sam McCall via Phabricator via cfe-commits]

sammccall marked 2 inline comments as done.
sammccall added inline comments.


================
Comment at: clangd/CodeComplete.cpp:308
+    return None;
+  }
+}
----------------
hokein wrote:
> add `return None` to make compiler happier? I think it might trigger -Wreturn-type warning.
added llvm_unreachable.


================
Comment at: clangd/CodeComplete.cpp:845
+    for (const auto &IndexResult : IndexResults) {
+      if (UsedIndexResults.count(&IndexResult))
+        continue;
----------------
hokein wrote:
> consider using `llvm::set_difference` here?
The value type is different: Symbol vs Symbol*


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D42181