[PATCH] D42181: [clangd] Merge index-provided completions with those from Sema.

[Eric Liu via Phabricator via cfe-commits]

ioeric added a comment.

LGTM



================
Comment at: clangd/CodeComplete.cpp:743
+  int NSema = 0, NIndex = 0, NBoth = 0; // Counters for logging.
+  bool Incomplete = false;
+  llvm::Optional<FuzzyMatcher> Filter; // Initialized once Sema runs.
----------------
`InComplete` can probably be output variable of `queryIndex` and `addCandidate` instead of a state?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D42181