[PATCH] D41852: [clang-tidy] Don't generate fix for argument constructed from std::initializer_list.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 19 02:43:43 PST 2018


ilya-biryukov added inline comments.


================
Comment at: test/clang-tidy/Inputs/modernize-smart-ptr/initializer_list.h:30
   vector(initializer_list<_E> init);
+  ~vector();
 };
----------------
hokein wrote:
> ilya-biryukov wrote:
> > hokein wrote:
> > > ilya-biryukov wrote:
> > > > Why do we need to add this destructor in this patch?
> > > Yeah, we do need it to reproduce the issue in real world. The AST is different with/without the destructor.
> > Because without destructor `CXXBindTemporaryExpr` does not show up?
> Yes.
Thanks for explaining clang's AST to me :-)


Repository:
  rL LLVM

https://reviews.llvm.org/D41852





More information about the cfe-commits mailing list