[PATCH] D42187: [clang-format] Adds a canonical delimiter to raw string formatting

Benjamin Kramer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 18 10:35:07 PST 2018


bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.

lg



================
Comment at: lib/Format/ContinuationIndenter.cpp:1336
+  unsigned OldSuffixSize = 2 + OldDelimiter.size();
+  std::string RawText =
+      Current.TokenText.substr(OldPrefixSize).drop_back(OldSuffixSize);
----------------
Can this be a StringRef? Can RawText outlive the Current token?


Repository:
  rC Clang

https://reviews.llvm.org/D42187





More information about the cfe-commits mailing list