r322769 - [RISCV] Propagate -mabi and -march values to GNU assembler.

[Alex Bradbury via cfe-commits]

On 18 January 2018 at 00:38, Rafael Avila de Espindola via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
> With this I am getting a test failure on linux:
>
> ******************** TEST 'Clang :: Driver/riscv-gnutools.c' FAILED ********************
> Script:
> --
> /home/admin/llvm/build/bin/clang -target riscv32-linux-unknown-elf -fno-integrated-as  --gcc-toolchain=/home/admin/llvm/llvm-project/clang/test/Driver/Inputs/multilib_riscv_linux_sdk  --sysroot=/home/admin/llvm/llvm-project/clang/test/Driver/Inputs/multilib_riscv_linux_sdk/sysroot /home/admin/llvm/llvm-project/clang/test/Driver/riscv-gnutools.c -###  2>&1 | /home/admin/llvm/build/bin/FileCheck -check-prefix=MABI-ILP32 /home/admin/llvm/llvm-project/clang/test/Driver/riscv-gnutools.c
> /home/admin/llvm/build/bin/clang -target riscv32-linux-unknown-elf -fno-integrated-as  -march=rv32g --gcc-toolchain=/home/admin/llvm/llvm-project/clang/test/Driver/Inputs/multilib_riscv_linux_sdk  --sysroot=/home/admin/llvm/llvm-project/clang/test/Driver/Inputs/multilib_riscv_linux_sdk/sysroot /home/admin/llvm/llvm-project/clang/test/Driver/riscv-gnutools.c -###  2>&1 | /home/admin/llvm/build/bin/FileCheck -check-prefix=MABI-ILP32-MARCH-G /home/admin/llvm/llvm-project/clang/test/Driver/riscv-gnutools.c
> --
> Exit Code: 1
>
> Command Output (stderr):
> --
> /home/admin/llvm/llvm-project/clang/test/Driver/riscv-gnutools.c:12:16: error: expected string not found in input
> // MABI-ILP32: "{{.*}}/Inputs/multilib_riscv_linux_sdk/lib/gcc/riscv64-unknown-linux-gnu/7.2.0/../../../../riscv64-unknown-linux-gnu/bin{{/|\\\\}}as" "-mabi" "ilp32"
>                ^
> <stdin>:1:1: note: scanning from here
> clang version 7.0.0
> ^
> <stdin>:7:42: note: possible intended match here
>  "/home/admin/llvm/llvm-project/clang/test/Driver/Inputs/multilib_riscv_linux_sdk/lib/gcc/riscv64-unknown-linux-gnu/7.2.0/../../../../riscv64-unknown-linux-gnu/bin/ld" "--sysroot=/home/admin/llvm/llvm-project/clang/test/Driver/Inputs/multilib_riscv_linux_sdk/sysroot" "--hash-style=both" "--eh-frame-hdr" "-m" "elf32lriscv" "-dynamic-linker" "/lib/ld-linux-riscv32-ilp32.so.1" "-o" "a.out" "crt1.o" "crti.o" "/home/admin/llvm/llvm-project/clang/test/Driver/Inputs/multilib_riscv_linux_sdk/lib/gcc/riscv64-unknown-linux-gnu/7.2.0/lib32/ilp32/crtbegin.o" "-L/home/admin/llvm/llvm-project/clang/test/Driver/Inputs/multilib_riscv_linux_sdk/lib/gcc/riscv64-unknown-linux-gnu/7.2.0/lib32/ilp32" "-L/home/admin/llvm/llvm-project/clang/test/Driver/Inputs/multilib_riscv_linux_sdk/sysroot/lib/../lib32" "-L/home/admin/llvm/llvm-project/clang/test/Driver/Inputs/multilib_riscv_linux_sdk/sysroot/lib32/ilp32" "-L/home/admin/llvm/llvm-project/clang/test/Driver/Inputs/multilib_riscv_linux_sdk/sysroot/usr/lib32/ilp32" "-L/home/admin/llvm/llvm-project/clang/test/Driver/Inputs/multilib_riscv_linux_sdk/sysroot/lib" "/tmp/lit_tmp_9u9TOy/riscv-gnutools-ebce8c.o" "-lgcc" "--as-needed" "-lgcc_s" "--no-as-needed" "-lc" "-lgcc" "--as-needed" "-lgcc_s" "--no-as-needed" "crtend.o" "crtn.o"
>                                          ^

Thanks for pasting the failure Rafael. I'm surprised that neither
/bin/as or Inputs/multilib_riscv_linux_sdk/riscv64-unknown-linux-gnu/bin/as
show up here at all. It does seem that the dummy `as` was added
without the svn:executable property. Ana: I believe you need to do
`svn propset svn:executable on $file` in order to have the executable
bit preserved. That seems a likely culprit, but as I say I would have
expected to see /usr/bin/as in the above.

Best,

Alex